Conversation
emberjs-rfcs-bot
added
RFC Advancement
S-Recommended
emberjs-rfcs-bot
force-pushed
the
advance-rfc-0756
branch
from
92d149f to
47dbda3
Compare
chriskrycho
approved these changes
Nov 23, 2022
Contributor
|
Here is the issue to track documentation work: ember-learn/guides-source#1881 |
jenweber
approved these changes
Jan 13, 2023
Contributor
There was a problem hiding this comment.
Looks good from the learning side! This is now documented and it has a blog post. I also opened a PR to add a note to the readme of ember-i-could-get-used-to-this
cc @emberjs/learning-core
jenweber
added a commit
to jenweber/ember-could-get-used-to-this
that referenced
this pull request
Jan 13, 2023
Add a note indicating that this is now built into Ember.js. This is part of implementing RFC 756 emberjs/rfcs#866
Contributor
|
Yay! |
chancancode
added a commit
to ember-learn/guides-source
that referenced
this pull request
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance #756 to the Recommended Stage
Summary
This pull request is advancing the RFC to the Recommended Stage.
An FCP is required before merging this PR to advance.
Recommended Stage Summary
The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.
To reach the "Recommended" stage, the following should be true:
If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
If the proposal updates or replaces an existing feature, high-quality codemods are available.
If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.
Checklist to move to Recommended
Final Comment Periodlabel has been added to start the FCPCriteria for moving to Recommended (required)
Since this was merged prior to the Stages RFC there were no prior criteria. However, the following have been identified as issues that should be been resolved earlier in the process:
A set of criteria for moving this RFC to the Recommended Stage, following release: