Skip to content

Advance RFC #0631 "RouterService#refresh" to Stage Recommended#913

Merged
ef4 merged 3 commits intomasterfrom
advance-rfc-0631
Aug 4, 2023
Merged

Advance RFC #0631 "RouterService#refresh" to Stage Recommended#913
ef4 merged 3 commits intomasterfrom
advance-rfc-0631

Conversation

@emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Mar 13, 2023

Advance #631 to the Recommended Stage

Summary

This pull request is advancing the RFC to the Recommended Stage.

An FCP is required before merging this PR to advance.

Recommended Stage Summary

The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.

To reach the "Recommended" stage, the following should be true:

If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.

If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.

If the proposal updates or replaces an existing feature, high-quality codemods are available.

If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.

If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".

Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.

An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.

Checklist to move to Recommended

  • Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met
  • If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
  • If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
  • If the proposal updates or replaces an existing feature, high-quality codemods are available
  • If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
  • If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP

Criteria for moving to Recommended (required)

  • Document in Guides

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Recommended PR to move to the Recommended Stage labels Mar 13, 2023
@ef4
Copy link
Contributor

ef4 commented Jul 28, 2023

We don't plan to do any additional work on this so we can call it recommended.

@ef4 ef4 added FCP to close The core-team that owns this RFC has moved that this RFC be closed. Final Comment Period and removed FCP to close The core-team that owns this RFC has moved that this RFC be closed. labels Jul 28, 2023
@ef4 ef4 marked this pull request as ready for review August 4, 2023 14:30
@ef4 ef4 merged commit 402b3bd into master Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the advance-rfc-0631 branch August 4, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants