RFC to allow setting dynamic query params in Controllers#922
Closed
bachvo wants to merge 5 commits intoemberjs:masterfrom
Closed
RFC to allow setting dynamic query params in Controllers#922bachvo wants to merge 5 commits intoemberjs:masterfrom
bachvo wants to merge 5 commits intoemberjs:masterfrom
Conversation
bachvo
changed the title
bachvo
changed the title
|
|
||
| ```js | ||
| // route/complex/filter-bar.js | ||
| setupController(controller, model) { |
Contributor
There was a problem hiding this comment.
Why use any API at all?
Could be enabled via optional-feature.json?
Personally, i'd like complexity removed from routes and controllers<3
Contributor
Author
There was a problem hiding this comment.
Oh yes that would be even better :)
Query params should just be available and maintained (unless explicitly removed) for all transitions, like how a vanilla web page links to other pages with query params
achambers
added
the
FCP to close
Contributor
|
Added "FCP to close" in light of the new router work that's ongoing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC to allow setting dynamic query params in Controllers
Rendered