Skip to content

Advance RFC #0854 "EmberData Cache V2.1" to Stage Ready for Release#923

Merged
runspired merged 3 commits intomasterfrom
advance-rfc-085421
Apr 5, 2023
Merged

Advance RFC #0854 "EmberData Cache V2.1" to Stage Ready for Release#923
runspired merged 3 commits intomasterfrom
advance-rfc-085421

Conversation

@emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Apr 5, 2023

Advance #085421 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

  • PR to Accepted Stage: #085421

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

  • Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
  • Any necessary learning materials have been updated
  • The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
  • Criteria for moving to the Recommended Stage has been filled out
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
  • Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
    • Framework @emberjs/framework
    • Data @emberjs/ember-data-core
    • CLI @emberjs/cli
    • Learning @emberjs/learning-core
    • Typescript @emberjs/typescript-core
    • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

  1. JSON:API Cache supports the full range of capabilities this RFC allows for
  2. Graph package is published as public API
  3. Documentation on how to approach authoring a new Cache implementation is provided

Track Implementation

  • JSON:API Cache was updated in 4.12
  • Documentation for using JSON:API Cache was added in 4.12
  • Documentation for the Cache API and Store APIs for Caches was added in 4.12
  • Documentation for Store coordinating between Cache and RequestManager was added in 4.12
  • All Cache v2.1 APIs are supported in 4.12, though the JSON:API Cache implementation does not itself yet support them all.

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage labels Apr 5, 2023
@runspired runspired requested a review from a team April 5, 2023 04:29
@runspired runspired marked this pull request as ready for review April 5, 2023 04:33
@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Apr 5, 2023
@runspired runspired merged commit 0ae8a29 into master Apr 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the advance-rfc-085421 branch April 5, 2023 04:35
@mansona mansona changed the title Advance RFC #085421 "EmberData Cache V2.1" to Stage Ready for Release Advance RFC #0854 "EmberData Cache V2.1" to Stage Ready for Release Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Comment Period RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage T-ember-data RFCs that impact the ember-data library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants