-
-
Notifications
You must be signed in to change notification settings - Fork 405
Make fn built-in in strict-mode #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
57c174c
Make fn built in
NullVoxPopuli 575f5ee
Write
NullVoxPopuli ef803c7
Update 0000-make-fn-built-in.md
NullVoxPopuli c012e50
Rename 0000-make-fn-built-in.md to 0998-make-fn-built-in.md
NullVoxPopuli 828ffab
Update text/0998-make-fn-built-in.md
NullVoxPopuli 74b942f
Update text/0998-make-fn-built-in.md
NullVoxPopuli 6775b37
Updates
NullVoxPopuli 928306e
Update text/0998-make-fn-built-in.md
NullVoxPopuli 05518b1
Merge branch 'master' into make-fn-built-in
achambers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| --- | ||
| stage: accepted | ||
| start-date: 2023-12-22T00:00:00.000Z | ||
| release-date: # In format YYYY-MM-DDT00:00:00.000Z | ||
| release-versions: | ||
| teams: # delete teams that aren't relevant | ||
| - framework | ||
| - learning | ||
| - typescript | ||
| prs: | ||
| accepted: https://github.com/emberjs/rfcs/pull/998 | ||
| project-link: | ||
| suite: | ||
| --- | ||
|
|
||
| <!--- | ||
| Directions for above: | ||
|
|
||
| stage: Leave as is | ||
| start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z | ||
| release-date: Leave as is | ||
| release-versions: Leave as is | ||
| teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies | ||
| prs: | ||
| accepted: Fill this in with the URL for the Proposal RFC PR | ||
| project-link: Leave as is | ||
| suite: Leave as is | ||
| --> | ||
|
|
||
| # Make `(fn)` a built in helper | ||
|
|
||
| ## Summary | ||
|
|
||
| Today, when using gjs/gts/`<template>`, in order to bind event listeners, folks _must import_ the `(fn)` helper. | ||
| Because partial application is so commonplace, this is a grating annoyance for developers. | ||
|
|
||
| This RFC proposes that `(fn)` be built in to `glimmer-vm` and not require importing. | ||
|
|
||
| ## Motivation | ||
|
|
||
| There is precedence for `fn` being built in, as all the other partialy-application utilities are already built in. | ||
|
|
||
| - `(helper)` | ||
| - `(modifier)` | ||
| - `(component)` | ||
|
|
||
| It's historically been the stance that, | ||
|
|
||
| "If it can be built in userspace, it should be, leaving the framework-y things to be only what can't exist in userspace" | ||
|
|
||
| But to achieve the ergonomics that our users want, we should provide a more cohesive experience, rather than require folks import from all of (in the same file): | ||
| - `@glimmer/component` | ||
| - `@glimmer/tracking` | ||
| - `@ember/modifier` | ||
| - `@ember/helper` | ||
| - `ember-modifier` | ||
| - `ember-resources` | ||
| - `tracked-built-ins` | ||
|
|
||
| Some of the above may unify in a separate RFC, but for the template-utilities, since the modules that provide them are already so small, it makes sense to inherently provide them by default. Especially as we can target strict-mode only, so that we don't run in to the same implementation struggles that built-in [Logical Operators](https://github.com/emberjs/rfcs/pull/562), [Numeric Comparison Operators](https://github.com/emberjs/rfcs/pull/561), and [Equality Operators](https://github.com/emberjs/rfcs/pull/560) have faced. | ||
|
|
||
| <details><summary>some context on those RFCs</summary> | ||
|
|
||
| The main problem with adding default utilities without strict-mode is that it becomes very hard to implement a way for an app to incrementally, and possibly per-addon, or per-file, to adopt the default thing due to how resolution works. Every usage of the built in utility would also require a global resolution lookup (the default behavior in loose mode templates) to see if an addon is overriding the built ins -- and then, how do you opt in to the built ins, and _not_ let addons override what you want to use? | ||
|
|
||
| With gjs/gts/`<template>`, this is much simpler, as in strict-mode, you can check if the scope object defines the helpers, and if not, use the built in ones. | ||
|
|
||
| This strategy of always allowing local scope to override default-provided utilities will be a recurring theme. | ||
|
|
||
| </details> | ||
|
|
||
| --------------- | ||
|
|
||
| _Making `fn` a built-in will help make writing components feel more cohesive and well supported, as folks will not need to cobble together many imported values_ | ||
|
|
||
| ---------------- | ||
|
|
||
|
|
||
| ## Detailed design | ||
|
|
||
| This change would affect strict-mode only. This is so that today's existing code that imports `fn` from `@ember/helper` will still work due to how values defined locally in scope override globals. | ||
|
|
||
| The behavior of `fn` would be the same as it is today, but defined by default in the `glimmer-vm`. | ||
|
|
||
| `fn` will be a keyword, and for backwards compatibility, this will require that keywords, in strict mode, be overrideable by the strict-mode scope bag. | ||
|
|
||
| ## How we teach this | ||
|
|
||
| Once implemented, the guides, if they say anything about gjs/gts/`<template>` and `fn` by the time this would be implemented, would only remove the import. | ||
|
|
||
| The guides should also detail which functions are built in to the framework and, therefore, do not need to be imported. | ||
|
|
||
| ## Drawbacks | ||
|
|
||
| People may not know where `fn` is defined. | ||
| - counterpoint: do they need to?, we are defining a lanugage, trying to make it ergonomic. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (small typo) |
||
|
|
||
| ## Alternatives | ||
|
|
||
| - Use a prelude | ||
| - preludes were mentioned during the initial exploration of strict-mode templates, and were decided against, because addons would not be able to assume a prelude exists, as apps could define their own, and this sort of re-introduces the app-tree-merging behavior that we've been trying to get away from. | ||
|
|
||
| ## Unresolved questions | ||
|
|
||
| - What happens if we want to remove a keyword? (like `mut`) | ||
| - same as today, we only need to commit to a major to remove the keyword in and then do it - providing ample deprecation time, ending with the final removal. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.