[WIP] Make model hooks run in parallel#171
Closed
nickiaconis wants to merge 1 commit intoemberjs:masterfrom
Closed
[WIP] Make model hooks run in parallel#171nickiaconis wants to merge 1 commit intoemberjs:masterfrom
nickiaconis wants to merge 1 commit intoemberjs:masterfrom
Conversation
nickiaconis
changed the title
Member
|
I'm closing in favor of https://github.com/nickiaconis/ember-prefetch ... does that seem reasonable? I don't believe that any of these patches are still required once we have the router service stuff landed. |
Author
|
Agree. Thanks for closing. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening for discussion on how to support running model hooks in parallel. From an IRL discussion with @wycats and @nathanhammond, this should be built as an addon, so that apps must explicitly opt into the functionality and related consequences. I am laying out the required changes directly in the source so we can plan how to hook into the necessary parts of Ember from that addon.
Most of the changes to make this work happen here, but parallel model hooks require changes to ember.js as well: emberjs/ember.js#12415