Merged
Conversation
rwjblue
reviewed
Oct 2, 2018
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Are there any tests specifically showing the interaction with the rootURL for recognizeAndLoad / recognize?
lib/router/route-info.ts
Outdated
| let { name, params, paramNames } = info; | ||
| let publicRouteInfo = new class implements RouteInfo { | ||
| let { name, params, paramNames, context } = info; | ||
| let RoutInfoImpl = class RoutInfoImpl { |
Member
There was a problem hiding this comment.
Do we actually need a class here? Seems like we could just use a POJO...
Contributor
Author
There was a problem hiding this comment.
If I do Object.assign is it going to get re-written to something in Ember?
Contributor
Author
|
I just copy and pasted these definitions from the RFC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 new APIs that were defined in emberjs/rfcs#95.
recognize: Takes a string URL and returns aRouteInfofor the leafmost route represented by the URL. Returns null if the URL is not recognized. This method expects to receive the actual URL as seen by the browser including the app'srootURL.recognizeAndLoad: Takes a string URL and returns a promise that resolves to aRouteInfoWithAttributesfor the leafmost route represented by the URL. The promise rejects if the URL is not recognized or an unhandled exception is encountered. This method expects to receive the actual URL as seen by the browser including the app's rootURL.