Merged
Conversation
tomdale
reviewed
Dec 5, 2018
| let { name, params, paramNames, context, route } = info; | ||
| if (ROUTE_INFOS.has(info) && includeAttributes) { | ||
| let routeInfo = ROUTE_INFOS.get(info)!; | ||
| routeInfo = attachMetadata(route!, routeInfo); |
Member
There was a problem hiding this comment.
Why do we need to assert route is non-null here? Is it guaranteed to be populated by this phase of the lifecycle?
Contributor
Author
There was a problem hiding this comment.
Yes, it is in a resolved state. This function is also used for the pre-resolved state.
rwjblue
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the router.js work required for emberjs/rfcs#398