Fix a type error when exactOptionalPropertyTypes is enabled#339
Merged
wagenet merged 1 commit intoemberjs:masterfrom Mar 19, 2024
boris-petrov:exactOptionalPropertyTypes
Merged
Fix a type error when exactOptionalPropertyTypes is enabled#339wagenet merged 1 commit intoemberjs:masterfrom boris-petrov:exactOptionalPropertyTypes
exactOptionalPropertyTypes is enabled#339wagenet merged 1 commit intoemberjs:masterfrom
boris-petrov:exactOptionalPropertyTypes
Conversation
Member
|
It seems like there would be a lot of other things affected by this, including the line immediately above: |
Contributor
Author
|
Right, this definitely doesn't fix all issues in this repo concerning |
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes emberjs/ember.js#20500
cc @wagenet