add Transition.waitFor() method#342
Open
frederikbosch wants to merge 3 commits intoemberjs:masterfrom
Open
Conversation
…l another promise has been resolved
Author
|
You can now also wait for query param changes, allowing those transitions to be part of a view transition too. |
Member
|
Since this would add public API to Ember, it requires an RFC |
Author
|
Thanks @kategengler, I was not aware. I will follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
Transition.waitFor()allows to wait for another promise to finish before continuing the transition into the new route. In particularly, if you want to add a view transition to the route change, this could look like this when this PR gets accepted.