Adds Component#isVisible deprecation#3403
Adds Component#isVisible deprecation#3403jayjayjpg merged 5 commits intoemberjs:blog/embertimes#51from Mi6u3l:patch-2
Conversation
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
This is a great write-up, I like the examples about how to deal with the deprecation in the future in particular! I left a question on how we'd like to mention the RFC - which has already been around for a while - again in the Ember Times now that it has entered Final Comment Period - let me know what you think!
|
|
||
| - `<div hidden={{boolean}}></div>` | ||
| - Wrapping the component in a template conditional `{{#if}}` statement. | ||
| - Using the Components `classNames` and `classNameBindings` |
There was a problem hiding this comment.
I think it would be
Using the Component's classNames and [...]
|
|
||
| ## [SECTION TITLE](#section-url) | ||
| ## [It's visibly time to deprecate isVisible 👀](https://github.com/emberjs/rfcs/pull/324) | ||
| A new RFC has been posted on deprecating `Component#isVisible`. The motivation is related to the confusion associated to setting the isVisible property on a component. Also, modern Ember applications are already avoiding using isVisible in favor of simpler conditionals in the template. Given that `Component#isVisible` is a public API, deprecating now would schedule for removal in the next major version release (4.0). |
There was a problem hiding this comment.
Technically, the RFC is not new, but it's definitely worth mentioning that it entered FCP which stands for Final Comment Period. Therefore I think it would be cool to remind readers that this week might be their last chance to comment on the RFC. Do you have advice on how to phrase this best?
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
Thank you for another great write-up this week! ✨
2 participants
What it does
Adds Component#isVisible deprecation write-up