Add section on Module Unification Packages by Alonski · Pull Request #3536 · emberjs/website

Alonski · 2018-08-29T17:34:22Z

This might be a bit too long? Not sure where to cut it or if I maybe need to add more?

What it does

Related Issue(s)

Sources

This might be a bit too long? Not sure where to cut it or if I maybe need to add more?

mixonic · 2018-08-30T12:27:36Z

source/blog/2018-08-31-the-ember-times-issue-62.md


-## [SECTION TITLE](#section-url)
+## [Module Unification with Ember Addons](https://github.com/emberjs/rfcs/pull/367) 🎁
+[Module Unification Packages](https://github.com/emberjs/rfcs/pull/367) is a new RFC, created by [@mixonic](https://github.com/mixonic), that sets out to describe how packages, **Ember Addons**, work and how apps and addons will migrate to the new [Module Unification](https://github.com/emberjs/rfcs/blob/master/text/0143-module-unification.md) structure from the classic structure. This RFC iterates on and is set to replace another RFC called [Module Unification Namespaces](https://github.com/emberjs/rfcs/pull/309) which had some syntax, like the `::` syntax, that proved problematic.


that sets out to describe how packages, Ember Addons

I suggest sticking with "describe how Ember apps and addons will migrate to the new...". The terminology of "package" is confusing if this is someones first introduction to the RFC. Focusing on "this is how addons and apps work under MU" is a good high level message.

Ok makes sense. Thanks

mixonic · 2018-08-30T12:29:13Z

source/blog/2018-08-31-the-ember-times-issue-62.md

+{{! invokes node_modules/gadget/src/ui/components/Widget/component.js }}
+
+{{use Widget from 'gadget'}}
+<Widget @options=someOptions @value=someValue />


My syntax here was incorrect, I need to fix it in the RFC. This should be:

{{! invokes node_modules/gadget/src/ui/components/Widget/component.js }} {{use Widget from 'gadget'}} <Widget @options={{someOptions}} @value={{someValue}} />

Oh good catch!

mixonic · 2018-08-30T12:31:25Z

source/blog/2018-08-31-the-ember-times-issue-62.md

+## [Module Unification with Ember Addons](https://github.com/emberjs/rfcs/pull/367) 🎁
+[Module Unification Packages](https://github.com/emberjs/rfcs/pull/367) is a new RFC, created by [@mixonic](https://github.com/mixonic), that sets out to describe how packages, **Ember Addons**, work and how apps and addons will migrate to the new [Module Unification](https://github.com/emberjs/rfcs/blob/master/text/0143-module-unification.md) structure from the classic structure. This RFC iterates on and is set to replace another RFC called [Module Unification Namespaces](https://github.com/emberjs/rfcs/pull/309) which had some syntax, like the `::` syntax, that proved problematic.
+
+This RFC proposes to add a new `{{use}}` helper that will be used to call external components that are provided by addons. This helper is a subset of the javascript imports that we are used to. 


Maybe:

This RFC proposes to add a new {{use}} helper. This helper imports components from an addon into an application's template. The helper provides a subset of the functionality JavaScript imports have, but is syntactically slightly different.

mixonic · 2018-08-30T12:33:49Z

source/blog/2018-08-31-the-ember-times-issue-62.md

+
+Something else that is proposed in this RFC is the use of a template `prelude.hbs` that, **at compile time**, will be injected into every template in the app. This can be used to inject global components such as the widely used `{{t 'token'}}` component used for *internationalization*. 
+
+Services also get some **love** in this RFC. The suggestion is that all service calls to addons will become more verbose in that the injected service will need to provide where to inject from. 


Perhaps:

Services also get some love in this RFC. The suggestion is that all service injections from an addon to an app will need to be explicit about their source package. This results in more verbosity, but also greater clarity and opportunity for optimizations.

mixonic · 2018-08-30T12:34:17Z

source/blog/2018-08-31-the-ember-times-issue-62.md

+});
+```
+
+There is also some proposals regarding `owner` APIs such as `owner.lookup()` and `owner.factoryFor()` which have also become more explicit.


There are also some proposals

mixonic · 2018-08-30T12:34:54Z

source/blog/2018-08-31-the-ember-times-issue-62.md

+There is also some proposals regarding `owner` APIs such as `owner.lookup()` and `owner.factoryFor()` which have also become more explicit.
+
+All in all this, **very well written**, RFC is a great chance to learn about possible changes to Ember and the Module Unification structure.
+If you have any concerns or questions feel free to ask in the [RFC issue](https://github.com/emberjs/rfcs/pull/367) and join in on the conversation.


join in the conversation by visiting #st-module-unification on Ember.js Community Slack.

Alonski · 2018-08-30T16:58:43Z

Finished fixing comments by @mixonic. Thanks for the help!

jayjayjpg

This reads great ✨ Thank you for another awesome writeup this week!

Add section on Module Unification Packages

5d3f8ad

This might be a bit too long? Not sure where to cut it or if I maybe need to add more?

Alonski requested review from a team and mixonic August 30, 2018 09:24

mixonic reviewed Aug 30, 2018

View reviewed changes

Fixed comments by @mixonic

10fb0e0

jayjayjpg approved these changes Aug 30, 2018

View reviewed changes

jayjayjpg merged commit d8a7a12 into blog/embertimes-62 Aug 30, 2018

jayjayjpg deleted the Alonski-Module-Unification-Packages branch August 31, 2018 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add section on Module Unification Packages#3536

Add section on Module Unification Packages#3536
jayjayjpg merged 2 commits intoblog/embertimes-62from
Alonski-Module-Unification-Packages

Alonski commented Aug 29, 2018

Uh oh!

mixonic Aug 30, 2018

Uh oh!

Alonski Aug 30, 2018

Uh oh!

mixonic Aug 30, 2018

Uh oh!

Alonski Aug 30, 2018

Uh oh!

mixonic Aug 30, 2018 •

edited

Loading

Uh oh!

mixonic Aug 30, 2018

Uh oh!

mixonic Aug 30, 2018

Uh oh!

mixonic Aug 30, 2018 •

edited

Loading

Uh oh!

Alonski commented Aug 30, 2018

Uh oh!

jayjayjpg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		Something else that is proposed in this RFC is the use of a template `prelude.hbs` that, at compile time, will be injected into every template in the app. This can be used to inject global components such as the widely used `{{t 'token'}}` component used for internationalization.

		Services also get some love in this RFC. The suggestion is that all service calls to addons will become more verbose in that the injected service will need to provide where to inject from.

Uh oh!

Conversation

Alonski commented Aug 29, 2018

What it does

Related Issue(s)

Sources

Uh oh!

mixonic Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

Alonski Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

mixonic Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

Alonski Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

mixonic Aug 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mixonic Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

mixonic Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

mixonic Aug 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alonski commented Aug 30, 2018

Uh oh!

jayjayjpg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mixonic Aug 30, 2018 •

edited

Loading

mixonic Aug 30, 2018 •

edited

Loading