Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

[Ember Times] Update embertimes-template.md#3550

Merged
jayjayjpg merged 4 commits intomasterfrom
amyrlam-patch-1
Sep 7, 2018
Merged

[Ember Times] Update embertimes-template.md#3550
jayjayjpg merged 4 commits intomasterfrom
amyrlam-patch-1

Conversation

@amyrlam
Copy link
Member

@amyrlam amyrlam commented Sep 6, 2018

This is repeated in every blog post on emberjs.com/blog. Put in Goodbits only? See #support-ember-times on Discord. cc @cah-danmonroe / @DanMonroe

@amyrlam amyrlam requested a review from a team September 6, 2018 17:46
@amyrlam amyrlam changed the title Update embertimes-template.md [Ember Times] Update embertimes-template.md Sep 6, 2018
@amyrlam
Copy link
Member Author

amyrlam commented Sep 6, 2018

Update #3540 if ok with this!

It seems like the invite link is the right link

<SAYING-HELLO-IN-YOUR-FAVORITE-LANGUAGE> Emberistas! 🐹

<goodbits-only>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one work like a HTML comment on the page?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No...just wasn't sure how to specify "template for Goodbits, but not the blog". Is a template on goodbits.com only a better way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay I see! Yes sure, I like your idea to just add it to goodbits - once we have it in one edition we can just copy over the template each week. Would you like to remove this section from the blog template then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it here, so this PR should be good to go.

I am not 100% sure what is the best way to create a template in Goodbits / create a new Goodbits (the couple times I did it from scratch it was a little time consuming). Maybe we could pair on Goodbits / take a video of you Goodbits-ing if possible? I can also help more in Goodbits so know this process better...

Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome, thank you for the swift update @amyrlam! ✨

@jayjayjpg jayjayjpg merged commit 477bfa5 into master Sep 7, 2018
amyrlam added a commit that referenced this pull request Sep 7, 2018
amyrlam added a commit that referenced this pull request Sep 7, 2018
amyrlam added a commit that referenced this pull request Sep 7, 2018
amyrlam added a commit that referenced this pull request Sep 7, 2018
@amyrlam amyrlam deleted the amyrlam-patch-1 branch September 7, 2018 07:41
amyrlam added a commit that referenced this pull request Sep 7, 2018
jayjayjpg pushed a commit that referenced this pull request Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants