Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

[Ember Times] Add alex linter ignores#3567

Merged
amyrlam merged 1 commit intoblog/embertimes-65from
alex-patch
Sep 20, 2018
Merged

[Ember Times] Add alex linter ignores#3567
amyrlam merged 1 commit intoblog/embertimes-65from
alex-patch

Conversation

@amyrlam
Copy link
Member

@amyrlam amyrlam commented Sep 20, 2018

Relates to: #3566

The build for #3566 passed, but when it was merged into #3563 it failed

@amyrlam amyrlam requested a review from a team September 20, 2018 03:26
amyrlam added a commit that referenced this pull request Sep 20, 2018
(Other warnings will be addressed by #3567)
Copy link
Contributor

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyrlam amyrlam merged commit 17f8b62 into blog/embertimes-65 Sep 20, 2018
@amyrlam amyrlam deleted the alex-patch branch September 20, 2018 15:48
@amyrlam
Copy link
Member Author

amyrlam commented Sep 20, 2018

I found it super confusing that the individual build didn't fail (and the builds are quite delayed since open source), but since we are just getting started with alex, seems ok!

I have alex working locally now...

(am confused by the VSCode plugin)

jayjayjpg pushed a commit to jayjayjpg/website that referenced this pull request Sep 26, 2018
(Other warnings will be addressed by emberjs#3567)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants