Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

[Ember Times] Add writing style guide#3568

Merged
jayjayjpg merged 1 commit intomasterfrom
amy/writing-style-guide
Sep 21, 2018
Merged

[Ember Times] Add writing style guide#3568
jayjayjpg merged 1 commit intomasterfrom
amy/writing-style-guide

Conversation

@amyrlam
Copy link
Member

@amyrlam amyrlam commented Sep 20, 2018

Change headers to Title Case, so not confusing

Change headers to Title Case, so not confusing
@amyrlam amyrlam requested a review from a team September 20, 2018 04:29
@amyrlam
Copy link
Member Author

amyrlam commented Sep 20, 2018

I tried to summarize what we tend to do, but nothing is set in stone - looking for feedback on the team to see what people think!

This is a living document and subject to change ✨ (that reminds me, maybe should add a comment about using emojis often)

@amyrlam amyrlam changed the title Add writing style guide [Ember Times] Add writing style guide Sep 20, 2018
amyrlam added a commit that referenced this pull request Sep 20, 2018
re: #3568, was thinking we could start doing this at the PR level
Copy link
Member

@kennethlarsen kennethlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

Copy link
Contributor

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

There is a tool available to gather the weekly contributions on Ember repos and to generate the contributors' list, here: [what-is-new-in-emberland](https://github.com/jessica-jordan/whats-new-in-emberland). It's an Ember app 🐹, you can simply download, build it and serve it!

### Pushing your changes to the blog post
### Pushing Your Changes to the Blog Post
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super useful, thank you @amyrlam!

@jayjayjpg jayjayjpg merged commit 979d072 into master Sep 21, 2018
jayjayjpg pushed a commit to jayjayjpg/website that referenced this pull request Sep 26, 2018
re: emberjs#3568, was thinking we could start doing this at the PR level
@amyrlam amyrlam deleted the amy/writing-style-guide branch September 28, 2018 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants