Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

[embertimes] workshop "about ember times" template#3575

Merged
amyrlam merged 4 commits intomasterfrom
amyrlam-patch-1
Sep 28, 2018
Merged

[embertimes] workshop "about ember times" template#3575
amyrlam merged 4 commits intomasterfrom
amyrlam-patch-1

Conversation

@amyrlam
Copy link
Member

@amyrlam amyrlam commented Sep 21, 2018

no need to review until the issue is out

@@ -79,7 +79,7 @@ responsive: true

Want to write for the Ember Times? Have a suggestion for next week's issue? Join us at #support-ember-times on the [Ember Community Discord](https://discordapp.com/invite/zT3asNS) or ping us [@embertimes](https://twitter.com/embertimes) on Twitter.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make this section #embertimes to match last week's Goodbits, or no heading

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the #embertimes title header looks cool, I'd be in for that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok changed it, let's give it a try

Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems great to me ✨ I just left my opinion on the title header for the contributors' section below

@amyrlam amyrlam merged commit a891c8f into master Sep 28, 2018
@amyrlam amyrlam deleted the amyrlam-patch-1 branch September 28, 2018 04:41
amyrlam added a commit that referenced this pull request Sep 28, 2018
- Edits from #3575 
- Remove greenkeeper from contributors list
@amyrlam amyrlam mentioned this pull request Sep 28, 2018
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants