This repository was archived by the owner on Mar 22, 2019. It is now read-only.
For Ember Times 66: Add Collocated Addon Test RFC Section#3580
Merged
jayjayjpg merged 1 commit intoemberjs:blog/embertimes-66from Sep 26, 2018
Merged
For Ember Times 66: Add Collocated Addon Test RFC Section#3580jayjayjpg merged 1 commit intoemberjs:blog/embertimes-66from
jayjayjpg merged 1 commit intoemberjs:blog/embertimes-66from
Conversation
jayjayjpg
force-pushed
the
embertimes-jj
branch
from
5d01bc1 to
7d907f3
Compare
chrisrng
reviewed
Sep 26, 2018
| ## [The Addon Test Is Right Where It Belongs ❤️](https://github.com/emberjs/rfcs/pull/378) | ||
|
|
||
| <!--alex ignore host-hostess--> | ||
| Spending too much time looking for the **test files** of your **in-repo addon**? Feeling exhausted to maintain a large test suite in which addon and host app test cases are meshed together? It doesn't have to be this way. |
Contributor
There was a problem hiding this comment.
Minor nit "Feeling exhausted to maintain a large test suite" --> "Feeling too exhausted to maintain a large test suite"
jayjayjpg
force-pushed
the
embertimes-jj
branch
from
7d907f3 to
b333ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Related Issue(s)
Sources