This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Section on missing docs#3584
Merged
kennethlarsen merged 2 commits intoemberjs:blog/embertimes-66from Sep 28, 2018
Merged
Conversation
jayjayjpg
reviewed
Sep 28, 2018
Member
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
This reads great! ✨ I just left one minor comment on wording, otherwise this seems all good to 🍏
|
|
||
| ## [SECTION TITLE](#section-url) | ||
| ## [The Missing Docs Has Returned](https://github.com/emberjs/ember.js/pull/17002) | ||
| There has been [some documentation missing](https://github.com/emberjs/ember.js/issues/16993) from the Ember API docs from the release of 3.3 to 3.4. [@Gaurav0](https://github.com/Gaurav0) has done some great detective work 🕵 and [fixed these issues](https://github.com/emberjs/ember.js/pull/17002) which means that **the missing documentation now is back.** |
Member
There was a problem hiding this comment.
I think it would be
[...] means that **the missing documentation is back now.**
Alonski
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.