This repository was archived by the owner on Mar 22, 2019. It is now read-only.
For EmberTimes No. 73: EmberConf CfP + Ember Hooks#3687
Merged
amyrlam merged 3 commits intoemberjs:blog/embertimes-73from Nov 14, 2018
Merged
For EmberTimes No. 73: EmberConf CfP + Ember Hooks#3687amyrlam merged 3 commits intoemberjs:blog/embertimes-73from
amyrlam merged 3 commits intoemberjs:blog/embertimes-73from
Conversation
jayjayjpg
force-pushed
the
embertimes-jj
branch
from
aa7151b to
9bc4347
Compare
jayjayjpg
force-pushed
the
embertimes-jj
branch
from
9bc4347 to
0f5aad7
Compare
amyrlam
reviewed
Nov 14, 2018
amyrlam
reviewed
Nov 14, 2018
amyrlam
reviewed
Nov 14, 2018
|
|
||
| ## [SECTION TITLE](#section-url) | ||
| <!--alex ignore hooks--> | ||
| ## [Embereact Hooks ⚛️ ](https://github.com/lifeart/hooked-components) |
Member
There was a problem hiding this comment.
Suggested change
| ## [Embereact Hooks ⚛️ ](https://github.com/lifeart/hooked-components) | |
| ## [Embereact Hooks ⚛️](https://github.com/lifeart/hooked-components) |
amyrlam
reviewed
Nov 14, 2018
blog(embertimes#73): add review suggestions Co-Authored-By: jessica-jordan <jessica.jordan.fe.dev@gmail.com>
Member
Author
|
@amyrlam Thank you for all the suggestions, updated ✨ |
amyrlam
approved these changes
Nov 14, 2018
Member
amyrlam
left a comment
amyrlam
left a comment
There was a problem hiding this comment.
Thanks for making the changes! 💛
There is an alex failure but it's strange since you've mentioned <!--alex ignore hooks--> on every new paragraph? If if fails on merge will look into it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Related Issue(s)
Sources