This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Ember in VSCode help wanted writeup#3700
Merged
amyrlam merged 2 commits intoblog/embertimes-74from Nov 22, 2018
Merged
Conversation
kennethlarsen
approved these changes
Nov 22, 2018
Member
kennethlarsen
left a comment
kennethlarsen
left a comment
There was a problem hiding this comment.
This reads great, Amy ✨
Would it make sense to add that if someone wants to do this as their first open source contribution they can always drop by the learning channel for help getting started?
jayjayjpg
approved these changes
Nov 22, 2018
Member
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
This reads great ✨ I suggested a change in regards to @kennethlarsen's review - feel free to apply if it makes sense to you, too!
Co-Authored-By: amyrlam <amy.r.lam@gmail.com>
Member
Author
|
thanks, great suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know what you think