Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

Added section on JSON:API 1.1 RC1#3718

Merged
jayjayjpg merged 4 commits intoblog/embertimes-76from
Alonski-patch-1
Dec 7, 2018
Merged

Added section on JSON:API 1.1 RC1#3718
jayjayjpg merged 4 commits intoblog/embertimes-76from
Alonski-patch-1

Conversation

@Alonski
Copy link
Member

@Alonski Alonski commented Dec 7, 2018

What it does

Related Issue(s)

Sources

@locks locks temporarily deployed to ember-website-staging-pr-3718 December 7, 2018 07:47 Inactive
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great ✨ I only left one small comment and do you also have time to

  • rebase the branch on blog/embertimes-76
  • add a short teaser for this section to the intro?

@locks locks temporarily deployed to ember-website-staging-pr-3718 December 7, 2018 12:36 Inactive
Co-Authored-By: Alonski <alonzorz@gmail.com>
@locks locks temporarily deployed to ember-website-staging-pr-3718 December 7, 2018 12:36 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3718 December 7, 2018 12:38 Inactive
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another great writeup this week - this reads ✨!

@jayjayjpg jayjayjpg merged commit a6f7021 into blog/embertimes-76 Dec 7, 2018
---
title: The Ember Times - Issue No. 76
author: Chris Ng, Jessica Jordan, Amy Lam, the crowd
author: Chris Ng, Jessica Jordan, Amy Lam, Alon Bukai the crowd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a comma missing, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spruce we removed the crowd in the post, should be ok in the main file here? note: we don't always follow oxford comma

@sivakumar-kailasam sivakumar-kailasam deleted the Alonski-patch-1 branch December 20, 2018 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants