This repository was archived by the owner on Mar 22, 2019. It is now read-only.
blog(embertimes77): component patterns#3726
Merged
chrisrng merged 3 commits intoblog/embertimes-77from Dec 12, 2018
Merged
Conversation
jayjayjpg
reviewed
Dec 12, 2018
Member
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
This reads great ✨ Just one more suggestion from my side!
Co-Authored-By: chrisrng <chrisrng@users.noreply.github.com>
jayjayjpg
approved these changes
Dec 12, 2018
Member
jayjayjpg
left a comment
jayjayjpg
left a comment
There was a problem hiding this comment.
✨ Thank you for another great writeup this week!
kenigbolo
reviewed
Dec 12, 2018
| <SAYING-HELLO-IN-YOUR-FAVORITE-LANGUAGE> Emberistas! 🐹 | ||
|
|
||
| <SOME-INTRO-HERE-TO-KEEP-THEM-SUBSCRIBERS-READING> | ||
| <SOME-INTRO-HERE-TO-KEEP-THEM-SUBSCRIBERS-READING>, want to learn more about component patterns 📚🧐? |
There was a problem hiding this comment.
qq here just for the purpose of clarity so I don't misunderstand this, I'm assuming <SOME-INTRO-HERE-TO-KEEP-THEM-SUBSCRIBERS-READING> ideally should be deleted and replaced with the catchy intro
Member
There was a problem hiding this comment.
We add to the intro with each writeup, but sometimes the order of articles changes. SOME-INTRO-HERE is more there as a reminder for writers to add to the intro with each PR. We delete it at the end!
|
Thanks for the clarification @amyrlam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.