Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

WIP DecEmber gift section#3764

Merged
jayjayjpg merged 7 commits intoblog/embertimes-80from
DecEmber-gift-section
Jan 11, 2019
Merged

WIP DecEmber gift section#3764
jayjayjpg merged 7 commits intoblog/embertimes-80from
DecEmber-gift-section

Conversation

@Alonski
Copy link
Member

@Alonski Alonski commented Jan 11, 2019

What it does

Related Issue(s)

Sources

@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 08:15 Inactive
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left two more small suggestions, otherwise this seems to be good to 🚀

@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 10:16 Inactive
@Alonski
Copy link
Member Author

Alonski commented Jan 11, 2019

@jessica-jordan i need an hour or so to finish this. It's my birthday so celebrating right now :)

@jayjayjpg
Copy link
Member

Wow thank you for making the time today and Happy Birthday 🎉

@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 13:07 Inactive
Co-Authored-By: Alonski <alonzorz@gmail.com>
@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 13:07 Inactive
Co-Authored-By: Alonski <alonzorz@gmail.com>
@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 13:08 Inactive
@locks locks temporarily deployed to ember-website-staging-pr-3764 January 11, 2019 13:24 Inactive
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for another ✨ writeup this week!

@jayjayjpg jayjayjpg merged commit 5013680 into blog/embertimes-80 Jan 11, 2019
@jayjayjpg jayjayjpg deleted the DecEmber-gift-section branch January 17, 2019 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants