This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Add section on Deprecate Partials RFC#3834
Merged
amyrlam merged 3 commits intoblog/embertimes-86from Feb 22, 2019
Merged
Conversation
amyrlam
approved these changes
Feb 21, 2019
Member
amyrlam
left a comment
amyrlam
left a comment
There was a problem hiding this comment.
TIL pre-RFC 😅
Thanks for another 💯 writeup, left a couple copy suggestions
| --- | ||
|
|
||
| <SAYING-HELLO-IN-YOUR-FAVORITE-LANGUAGE> Emberistas! 🐹 | ||
| สวัสดี Emberistas! 🐹 |
|
|
||
| ## [SECTION TITLE](#section-url) | ||
|
|
||
| ## [Lets Fully Deprecate Partials! 🥛](https://github.com/emberjs/rfcs/pull/449) |
Member
There was a problem hiding this comment.
Suggested change
| ## [Lets Fully Deprecate Partials! 🥛](https://github.com/emberjs/rfcs/pull/449) | |
| ## [Let's Fully Deprecate Partials! 🥛](https://github.com/emberjs/rfcs/pull/449) |
| ## [SECTION TITLE](#section-url) | ||
|
|
||
| ## [Lets Fully Deprecate Partials! 🥛](https://github.com/emberjs/rfcs/pull/449) | ||
| Partials in Ember have been around for quite some time. Today however they are considered bad practice and all of their functionality can be replaced with Components. There is an [Ember Template Lint Rule](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-partial.md) against their use. There was a [Pre-RFC](https://github.com/emberjs/rfcs/issues/390) created a while ago that recommended deprecating partials. Today we finally have a full RFC to [Deprecate Partials](https://github.com/emberjs/rfcs/pull/449) written up by [@GavinJoyce](https://github.com/GavinJoyce). If you want to learn more about the deprecation or maybe the alternatives to partials [check out the RFC](https://github.com/gavinjoyce/rfcs/blob/gj/deprecate-partials/text/0000-template.md). Also be sure to chime in and voice your concerns or add a 👍🎉 to the [RFC itself](https://github.com/emberjs/rfcs/pull/449). |
Member
There was a problem hiding this comment.
Suggested change
| Partials in Ember have been around for quite some time. Today however they are considered bad practice and all of their functionality can be replaced with Components. There is an [Ember Template Lint Rule](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-partial.md) against their use. There was a [Pre-RFC](https://github.com/emberjs/rfcs/issues/390) created a while ago that recommended deprecating partials. Today we finally have a full RFC to [Deprecate Partials](https://github.com/emberjs/rfcs/pull/449) written up by [@GavinJoyce](https://github.com/GavinJoyce). If you want to learn more about the deprecation or maybe the alternatives to partials [check out the RFC](https://github.com/gavinjoyce/rfcs/blob/gj/deprecate-partials/text/0000-template.md). Also be sure to chime in and voice your concerns or add a 👍🎉 to the [RFC itself](https://github.com/emberjs/rfcs/pull/449). | |
| Partials in Ember have been around for quite some time. Today however they are considered bad practice and all of their functionality can be replaced with Components. There is an [Ember Template Lint rule](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-partial.md) against their use. There was a [Pre-RFC](https://github.com/emberjs/rfcs/issues/390) created a while ago that recommended deprecating partials. Today we finally have a full RFC to [Deprecate Partials](https://github.com/emberjs/rfcs/pull/449) written up by [@GavinJoyce](https://github.com/GavinJoyce). If you want to learn more about the deprecation or maybe the alternatives to partials [check out the RFC](https://github.com/gavinjoyce/rfcs/blob/gj/deprecate-partials/text/0000-template.md). Also be sure to chime in and voice your concerns or add a 👍🎉 to the [RFC itself](https://github.com/emberjs/rfcs/pull/449). |
Member
|
I went ahead and committed the suggestions so can get a head start on combining everything. Further edits can be made as needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Related Issue(s)
Sources