Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

{{render}} helper not documented in Ember Guides#402

Merged
stefanpenner merged 3 commits intoemberjs:masterfrom
mharris717:guide_render_helper
Apr 13, 2013
Merged

{{render}} helper not documented in Ember Guides#402
stefanpenner merged 3 commits intoemberjs:masterfrom
mharris717:guide_render_helper

Conversation

@mharris717
Copy link
Contributor

No description provided.

@mharris717
Copy link
Contributor Author

I am happy to do this if someone wants to assign me.

It looks like partial is also not documented in the guide. Given that, I was thinking of adding a "ways to render stuff" page under Templates that covers at least partial and render.

@mharris717
Copy link
Contributor Author

I put a pull request on this issue.

Huge thanks to darthdeus, author of this post: http://darthdeus.github.com/blog/2013/02/10/render-control-partial-view/

This is just a first cut. I figured it's better for the guides to discuss these helpers so people know about them, even if we do want to change or enhance what's here.

Happy to make any changes.

@stefanpenner
Copy link
Member

this is looking good, let me know when its ready.

I made some of the changes recommended by fivetanley.

I added some more example code.  I hesitate to add too much, as at some point it turns from a guide into an example app.

Added some more notes about {{render}}, including a brief comparison of {{outlet}} and {{render}}, which I hope is not confusing.

Added a comparison table of the three main rendering helpers.
@mharris717
Copy link
Contributor Author

Made some changes, listed in the commit msg.

Tried to use my judgement on a couple things, but I'm happy to change anything. Trying to strike the right balance between complete and overkill.

@mharris717
Copy link
Contributor Author

Also, I don't know what your best practice is regarding squashing commits when it's time to merge. Happy to move my commit history around when the time comes.

@tomdale
Copy link
Member

tomdale commented Mar 28, 2013

Can we brainstorm some names other than "Rendering Helpers"? To me, I read this as "how helpers are rendered" and not "helpers for rendering". Maybe something like "Including Templates"?

@mharris717
Copy link
Contributor Author

Agreed on the name. "Including Templates" is reasonable to me.

My only concern would be that {{render}} doesn't just include a template. But I have no strong opinions on the title.

I'll think for a bit and see if I come up with anything better.

@mharris717
Copy link
Contributor Author

Title Suggestion: Rendering with Helpers

@davejachimiak
Copy link
Contributor

"Rendering with Helpers" sounds like a good name. Nice work on this @mharris717, and props to @darthdeus for the post that inspired this pull.

FWIW I've spent a couple days trying to figure out how to do what's in this pull before just discovering it now. Considering how conventional the functionality is, it would be good for the community to see this @ /guides sooner than later. 😄

@tomdale
Copy link
Member

tomdale commented Apr 13, 2013

👍 on getting the title updated and merged ASAP

stefanpenner added a commit that referenced this pull request Apr 13, 2013
{{render}} helper not documented in Ember Guides
@stefanpenner stefanpenner merged commit 4b4be40 into emberjs:master Apr 13, 2013
@stefanpenner
Copy link
Member

this will go live shortly.

@mharris717
Copy link
Contributor Author

Awesome. If you have something else in the guides you've been looking to add or update, let me know and I can take a crack at it.

@stefanpenner
Copy link
Member

@mharris717 thanks!

If general improvements to the guides or api is always appreciated. If you are interested, one of the big ticket items that must be championed is: #237

@mharris717
Copy link
Contributor Author

Sure thing, I'll take a look at #237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants