add "total score" and average score to maintainers page#179
add "total score" and average score to maintainers page#179mansona wants to merge 1 commit intoemberobserver:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 80.63% 80.31% -0.33%
==========================================
Files 131 132 +1
Lines 945 955 +10
==========================================
+ Hits 762 767 +5
- Misses 183 188 +5
Continue to review full report at Codecov.
|
|
I applaud the initiative but I really don't like showing a score for a person, especially because the maintainers page list shows any addon the username has been given access to on npm. |
|
@kategengler feel free to close! I figured it might not be something that you would want to add and it only took me 10 mins anyway. On a related note: if I wanted to make an app that showed these metrics would that be ok? or would that be an improper use of Ember Observer data or the API? 🤔 |
|
@mansona Well, there is no publicly supported API. As I mentioned, that list is every addon a username on npm has access to, an "npm maintainer", not necessarily every addon a username takes ownership of -- For example, I assure you I have not even touched at least half of these addons https://emberobserver.com/maintainers/katiegengler I understand the potential gamification, but I think a score based on that list may inadvertently cause people to remove their access from addons on npm, effectively increasing the bus-factor for those addons. That said, I have wanted to improve the maintainers page: Get it to list addons the user commits to as well (tricky since npm and github usernames often differ), sort the addons by the quantity of contributions of that person, separate out the addons the user "owns" -- and for an ownership list, I would be ok with the score. |
This PR is mostly to open up a discussion, the styling of the change isn't ready to be merged and I'm not even sure it's something that we would want to add 😂
Anyway, I saw someone share https://emberobserver.com/maintainers/rwjblue in the Community Discord and I thought "wow that is an impressive number of addons, but the number isn't big enough" 😂 so I thought a better metric would be to count up all the Ember Observer "points" that he has from each of the addons.
I also thought this might serve as a slight gamification (especially with the average score) that might encourage more maintainers to update their addons, but I don't know 🤷♂
(also for the record @rwjblue does not need gamification to make him do more 🙈)