Skip to content

Save raw result JSON from ember-try#67

Merged
pgengler merged 4 commits intomasterfrom
save-test-results
Jan 26, 2020
Merged

Save raw result JSON from ember-try#67
pgengler merged 4 commits intomasterfrom
save-test-results

Conversation

@pgengler
Copy link
Collaborator

@pgengler pgengler commented Oct 1, 2019

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #67 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   96.93%   96.94%   +<.01%     
==========================================
  Files         194      194              
  Lines        3725     3729       +4     
==========================================
+ Hits         3611     3615       +4     
  Misses        114      114
Impacted Files Coverage Δ
test/factories/test_results.rb 100% <ø> (ø) ⬆️
app/models/test_result.rb 100% <ø> (ø) ⬆️
test/integration/api/v2/test_result_test.rb 100% <ø> (ø) ⬆️
test/models/test_result_test.rb 100% <ø> (ø) ⬆️
app/controllers/test_results_controller.rb 100% <100%> (ø) ⬆️
test/controllers/test_results_controller_test.rb 100% <100%> (ø) ⬆️
app/resources/api/v2/test_result_resource.rb 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8f066...d3f919b. Read the comment docs.

addon_version_id: build.addon_version.id,
build_server: build.build_server,
canary: build.canary?,
ember_try_results: @results,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the easiest to tell where @results comes from

@pgengler pgengler merged commit cfe622f into master Jan 26, 2020
@pgengler pgengler deleted the save-test-results branch January 26, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants