Call cleanup before handlers for menu #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npentrel
force-pushed
the
add-cleanup-calls
branch
from
ead78cf to
5c33559
Compare
Contributor
Author
|
@MatthewWilkes and @hughrawlinson how do we feel about this? |
Member
|
@npentrel So, I am not 100% on this, I think it's good for people not to have to call the cleanup method, but I think this would mean that all menu selects or cancels would have to tear down the menu, which I think limits the usages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way menu's work I don't think we should require users to call the
_cleanup method. The underscore is supposed to mean it's internal anyway