Unable to call WaitAnswer a second time when the OnResponse callback returned an error

[serfreeman1337]

Diago returns the ErrClientEarlyMedia error in the OnResponse callback to exit WaitAnswer early for 183 early media. It's expected to call WaitAnswer a second time to actually wait for a 200 OK response, but it fails with a transaction canceled message.

This happens because s.inviteTx is not updated after a new transaction request with authorization is made when OnResponse returns an error.

sipgo/dialog_client.go

Lines 324 to 329 in 8cd3738

	tx, err = s.TransactionRequest(ctx, inviteRequest)
	if err != nil {
	return err
	}
	continue

[emiago]

ok just to confirm to repeat this issue.
You are doing INVITE getting 183, doing WaitAnswer but after 183 you are getting digest challenge with 40X?

[serfreeman1337]

It's INVITE -> 401 -> 183 -> returning error in the OnResponse callback.

SIP Flow

diago example code

ua, _ := sipgo.NewUA(
	sipgo.WithUserAgent(username),
	sipgo.WithUserAgentHostname(host),
)
dg := diago.NewDiago(ua,
	diago.WithTransport(diago.Transport{
		Transport: "udp",
		BindHost:  "10.0.3.1",
	}),
	diago.WithMediaConfig(diago.MediaConfig{
		Codecs: []media.Codec{media.CodecAudioAlaw},
	}),
)
d, err := dg.NewDialog(sip.Uri{
	Scheme: "sip",
	User:   num,
	Host:   host,
}, diago.NewDialogOptions{})

if err != nil {
	return err
}

err = d.Invite(ctx, diago.InviteClientOptions{
	Username:         username,
	Password:         password,
	EarlyMediaDetect: true,
})

if err == nil || err == diago.ErrClientEarlyMedia {
	// Setup media reader for d.DialogMedia.
}

if err == diago.ErrClientEarlyMedia {
	// Wait for an answer after 183 early media.
	err = d.WaitAnswer(ctx, sipgo.AnswerOptions{
		Username:   username,
		Password:   password,
	})
}

if err != nil {
	return err
}

if err = d.Ack(ctx); err != nil {
	return err
}

s.inviteTx needs to be updated for a new transaction after StatusUnauthorized and StatusProxyAuthRequired:

tx, err = s.TransactionRequest(ctx, inviteRequest)
if err != nil {
	return err
}
+ s.inviteTx = tx