[DRAFT] Improve FileLoader file uri to path handling for windows#8163
Open
aconbere wants to merge 1 commit into
Open
[DRAFT] Improve FileLoader file uri to path handling for windows#8163aconbere wants to merge 1 commit into
aconbere wants to merge 1 commit into
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8163-fix-windows-file-uri-unc-handling View snapshot changes at kitdiff |
aconbere
changed the title
aconbere
commented
May 15, 2026
| // We need to load the file at `path`. | ||
|
|
||
| // Set the file to `pending` until we finish loading it. | ||
| let path = path.to_owned(); |
Author
There was a problem hiding this comment.
the pathbuf returned from convert_uri_to_path is already owned.
Author
|
I can confirm that with my local app this change fixes the behavior allowing both local paths and remote paths to work on windows. One of the test demo app tests are failing, and I'm not sure how to work with those yet. |
Current behavior fails when translating file uris that contain windows UNC paths. This commit attempts to fix that behavior by looking at the hostname attribute of the uri and changing behavior if the hostname is present.
emilk
approved these changes
May 18, 2026
emilk
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior fails when translating file uris that contain windows UNC paths. This commit attempts to fix that behavior by looking at the hostname attribute of the uri and changing behavior if the hostname is present.
Image::from_urifails to load images when attempting to load images from a windows network share. #8161