Skip to content

Conversation

@steinnhauser
Copy link
Collaborator

…ifact-removed data shapes and values

Reference issue (if any)

What does this implement/fix?

Additional information

emma-bailey and others added 7 commits November 27, 2024 10:26
… function input, ad tests for copying original data and comparing to data modified in-place, add window size checks and remove generic try-except blocks

BREAKING CHANGE
…ndices, add sanity checks for input values, add negative-test which verifies proper exceptions when bad data is passed to function
@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@steinnhauser
Copy link
Collaborator Author

Successful positive and negative tests implemented, feature seems ready for pull request into main library

@steinnhauser steinnhauser merged commit b8d8d7c into main Dec 18, 2024
10 of 18 checks passed
@steinnhauser steinnhauser deleted the tests/general-pca-obs branch December 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants