Conversation
sbc100
force-pushed
the
npm_install
branch
2 times, most recently
from
71c8f42 to
1e0c6dd
Compare
emsdk will run npm install in the version of emscripten that it downloads, but we override with our own version from git and we need to run `npm install` locally. Previously we only did this for the socket tests which are currently the only parts of emscripten that actually depend on `npm install` having been run. However we have plans to extend that. See #9989.
kripken
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emsdk will run npm install in the version of emscripten that it
downloads, but we override with our own version from git and we need
to run
npm installlocally.Previously we only did this for the socket tests which are currently
the only parts of emscripten that actually depend on
npm installhaving been run. However we have plans to extend that. See #9989.