Skip to content

Remove a static allocation in C++ exceptions support code in JS #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kripken merged 4 commits into from
Aug 25, 2020
Merged

Remove a static allocation in C++ exceptions support code in JS #12039

kripken merged 4 commits into from
Aug 25, 2020

Conversation

@kripken
Copy link
Member

@kripken kripken commented Aug 25, 2020

This also fixes a potential issue with thread-safety (as all threads used
to use that same location, previously).

@kripken kripken requested a review from sbc100 August 25, 2020 21:27
@kripken kripken mentioned this pull request Aug 25, 2020
Closed
@kripken kripken merged commit c233703 into master Aug 25, 2020
@kripken kripken deleted the nostat-exc branch August 25, 2020 22:12
@juj juj mentioned this pull request Aug 26, 2020
Merged
@aheejin aheejin mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kripken @sbc100