Rebaseline test_minimal_runtime_code_size test results. NFC #12762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 11, 2020
| "a.html.gz": 386, | ||
| "a.js": 20852, | ||
| "a.js.gz": 8105, | ||
| "a.js": 20785, |
Member
There was a problem hiding this comment.
i'm confused, how was a win of this size not causing an error on the test? it's larger than the slop factor.
Collaborator
Author
There was a problem hiding this comment.
IIUC, it is causing an error on the test.. we only run these tests on CI so that they don't show up until after the roll, right?
Member
There was a problem hiding this comment.
Oh, it was erroring on CI here on github? I've been too busy to notice 😄 sgtm
Member
There was a problem hiding this comment.
(yes, we don't test these on chromium CI, only here)
This captures some minor code size win from (I belive) WebAssembly/binaryen#3323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This captures some minor code size win from (I belive)
WebAssembly/binaryen#3323