Remove PThread.mainThreadFutex from JavaScript. NFC #12887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is initialized from `_main_thread_futex` which is a data address exported from native code. Rather than copy it we can simply use that variable directly. I think it made sense to have a seperate JS variable in the past when this address was allocated at runtime, but since #12318 landed it is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is initialized from
_main_thread_futexwhich is a dataaddress exported from native code. Rather than copy it we can simply
use that variable directly.
I think it made sense to have a seperate JS variable in the past when
this address was allocated at runtime, but since #12318 landed it
is no longer needed.
Also rename the exported variable to avoid conflict with user symbols.