Simplify emscripten_futex_wait on them main thread#15975
Closed
Conversation
The `_emscripten_futex_wait_non_blocking` contains a busy loop that and was calling out to `emscripten_main_thread_process_queued_calls` on each iteration. However, all the caller of `emscripten_futex_wait` already do their own busy loop calling `emscripten_main_thread_process_queued_calls`. See: - __wait.c: __wait - __timed_wait.c: __timedwait_cp - pthread_barrier_wait.c: pthread_barrier_wait - pthread_join.c: __pthread_join_internal - library_pthread.c: emscripten_thread_sleep In all these cases `emscripten_futex_wait` is limited to a max sleep of 1ms when running on the main thread. There is only one of other user and in this case emscripten_fetch_wait is only used when not running on the main thread: - emscripten_fetch.c: emscripten_fetch_wait
sbc100
force-pushed
the
simplify_futex_wait
branch
from
f18ebe5 to
6b52611
Compare
Collaborator
Author
|
I think perhaps we should instead remove all the other time slicing instead and keep this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_emscripten_futex_wait_non_blockingcontains a busy loop that andwas calling out to
emscripten_main_thread_process_queued_callson eachiteration. However, all the caller of
emscripten_futex_waitalreadydo their own busy loop calling
emscripten_main_thread_process_queued_calls. See:In all these cases
emscripten_futex_waitis limited to a max sleep of1ms when running on the main thread.
There is only one of other user and in this case emscripten_fetch_wait
is only used when not running on the main thread: