Update expectations for other.test_metadce_minimal_pthreads after #15604 #16141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke the emscripten-releases roller as well as recent test runs on emscripten CI. I have no idea how it actually passed in #15604. That is rather worrying.
dschuff
approved these changes
Jan 28, 2022
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
LGTM, assuming this test change reflects the desired behavior of course :)
kripken
approved these changes
Jan 29, 2022
Member
|
Perhaps it passed before due to a race in landing, with maybe #16129 ? If so, I'd expect it to fail not just on the roller but also on main here, only after landing, which as you said is indeed the case. |
Collaborator
Author
|
Ah yes, that makes sense |
Collaborator
Author
|
I'm going to land this TBR, once (maybe once the mac build confirms that the other suite is all good).. to get things green again. |
Collaborator
Author
Sorry, not TBR, just land without waiting for all results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke the emscripten-releases roller as well as recent test
runs on emscripten CI.
I have no idea how it actually passed in #15604. That is rather
worrying.