Remove redundant alias handling in JS compiler. NFC#17419
Closed
Remove redundant alias handling in JS compiler. NFC#17419
Conversation
This alias handling code was not active. You can see this from the fact that the `deps` variable is declared const and then re-assigned in the case of an alias, which would have been a runtime error if it ever happended. Aliased are instead handed in modules.js. See `apply synonyms` in that file.
Collaborator
Author
|
I guess its possible we could instead remove the more complex alias handling that is currenty the active one (in modules.js)? |
sbc100
added a commit
that referenced
this pull request
Jul 12, 2022
This change removes the redudant handling of aliases, leaving the simpler and more effecient one in place. The alternative PR is #17419. With this method the final output contains: var foo = target; Rather than: function foo(arg1, arg2) { return target(arg1, arg1); }
Collaborator
Author
|
I think we can close this in favor of #17420 |
sbc100
added a commit
that referenced
this pull request
Jul 12, 2022
This change removes the redudant handling of aliases, leaving the simpler and more effecient one in place. The alternative PR is #17419. With this method the final output contains: var foo = target; Rather than: function foo(arg1, arg2) { return target(arg1, arg1); }
sbc100
added a commit
that referenced
this pull request
Jul 12, 2022
This change removes the redudant handling of aliases, leaving the simpler and more effecient one in place. The alternative PR is #17419. With this method the final output contains: var foo = target; Rather than: function foo(arg1, arg2) { return target(arg1, arg1); }
sbc100
added a commit
that referenced
this pull request
Jul 12, 2022
This change removes the redudant handling of aliases, leaving the simpler and more effecient one in place. The alternative PR is #17419. With this method the final output contains: var foo = target; Rather than: function foo(arg1, arg2) { return target(arg1, arg1); }
sbc100
added a commit
that referenced
this pull request
Jul 12, 2022
This change removes the redudant handling of aliases, leaving the simpler and more effecient one in place. The alternative PR is #17419. With this method the final output contains: var foo = target; Rather than: function foo(arg1, arg2) { return target(arg1, arg1); }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alias handling code was not active. You can see this from the
fact that the
depsvariable is declared const and then re-assignedin the case of an alias, which would have been a runtime error if it
ever happended.
Aliased are instead handed in modules.js. See
apply synonymsin thatfile.