Change HEAP8.length assert in SAFE_HEAP_LOAD/_STORE() to instead asse…#18170
Merged
juj merged 1 commit intoemscripten-core:mainfrom Nov 9, 2022
Merged
Change HEAP8.length assert in SAFE_HEAP_LOAD/_STORE() to instead asse…#18170juj merged 1 commit intoemscripten-core:mainfrom
juj merged 1 commit intoemscripten-core:mainfrom
Conversation
…rt against wasmMemory.buffer.byteLength, because HEAP8.length may be out of date if another thread races to sbrk(). Related to test case in emscripten-core#18096.
This was referenced Nov 9, 2022
kripken
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change HEAP8.length assert in SAFE_HEAP_LOAD/_STORE() to instead assert against wasmMemory.buffer.byteLength, because HEAP8.length may be out of date if another thread races to sbrk(). Related to test case in #18096.
Also improve the assert() tests to give a more meaningful assert failure.