Only use futex_wait_busy on the main browser thread#18402
Merged
Conversation
sbc100
force-pushed
the
futex_wait_busy
branch
3 times, most recently
from
90e7cab to
c28bd43
Compare
kripken
approved these changes
Dec 19, 2022
sbc100
force-pushed
the
futex_wait_busy
branch
from
c28bd43 to
af90642
Compare
sbc100
force-pushed
the
futex_wait_busy
branch
from
af90642 to
08d7cd1
Compare
When I ported this code from JS back in #15742 I mistakenly changed the semantics here. This change restores the previous behaviour of using atomic.wait except in on the main browser thread. The `futex_wait_busy` can clearly only be used a single main thread and is not appropriate for using in cases where there are other threads in the system that also don't support `atomic.wait` (such as IIUC audio worklets). To support that case we would need a different busy wait function that didn't depend on some global singleton like _emscripten_main_thread_futex.
sbc100
force-pushed
the
futex_wait_busy
branch
from
08d7cd1 to
7e24671
Compare
juj
added a commit
to juj/emscripten
that referenced
this pull request
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I ported this code from JS back in #15742 I mistakenly changed the semantics here. This change restores the previous behaviour of using atomic.wait except in on the main browser thread.
The
futex_wait_busycan clearly only be used a single main thread and is not appropriate for using in cases where there are other threads in the system that also don't supportatomic.wait(such as IIUC audio worklets). To support that case we would need a different busy wait function that didn't depend on some global singleton like _emscripten_main_thread_futex.