Ensure exports are correctly handled when instantiateWasm is present#18711
Merged
Ensure exports are correctly handled when instantiateWasm is present#18711
Conversation
sbc100
changed the title
sbc100
force-pushed
the
instantiateWasm_return_value
branch
2 times, most recently
from
5aa3d13 to
b466ba4
Compare
kripken
approved these changes
Feb 13, 2023
Split out from #18705 I noticed while working on #18705 that the exports returned by `instantiateWasm` (which is used in pthreads to load the wasm module) ere not the same (potentially wrapped/modified) exports that were created during `receiveInstance`. I guess someone else must have noticed this and added the extra call to `Asyncify.instrumentWasmExports`. This should not be necessary since `receiveInstance` already takes care of that.
sbc100
force-pushed
the
instantiateWasm_return_value
branch
from
b466ba4 to
52123b3
Compare
sbc100
added a commit
that referenced
this pull request
Oct 14, 2024
There are a two different fixes here, neither of which are needed except in the nightly version of chrome. 1. In the `instantiateWasm` override used in audio worklets return the result of `receiveInstance` rather then directly returning the wasm exports. This means that the resulting object has the needed wrappers applied. This was causing an exception even on older version of chrome, but the tests still passed regardless. With newer versions of chrome the exception seems to cause the worklet creation to fail. (see #18711) 2. Using BigInt when indexing the wasm table. I would have prefered to use `toIndexType` here but that doesn't work in `audio_worklet.js`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #18705
I noticed while working on #18705 that the exports returned by
instantiateWasm(which is used in pthreads to load the wasm module) ere not the same (potentially wrapped/modified) exports that were created duringreceiveInstance.I guess someone else must have noticed this and added the extra call to
Asyncify.instrumentWasmExports. This should not be necessary sincereceiveInstancealready takes care of that.