Conversation
fd591c3 to
a814d6e
Compare
This means we can run the tests without depending on the browser.
|
Will wait for @juj for final approval |
|
Actually I'm going to land this now since it seems fairly straight forward, and I could use this for debugging some other PRs. If the |
|
Interesting, I remembered that more changes were needed to fix Node.js compatibility, see e.g. PR #18201 (I should have split that PR back then, sorry). |
|
This change is minimal.. just enough to get the first few tests passing. There will more changes needed I'm sure to get the rest of them running. |
|
This seems to be causing a failure under LSan: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8781449586792126465/+/u/Emscripten_testsuite__LSan_/stdout |
|
Actually I guess the problem is not new, it's just that we weren't running this test outside of the browser before, right? |
|
Right, old bug newly visible I would guess |
This means we can run the tests without depending on the browser.