WasmFS JS API: Refactor tests #19628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jun 14, 2023
Member
|
(this has conflicts now) |
Member
|
(btw @jameshu15869 , we sometimes write "NFC" for "no functional changes" as a shorthand. I did that in the final commit now) |
Contributor
Author
|
Oh, that makes sense - I was wondering what NFC meant (Surprisingly Google searches only gave results about a different kind of NFC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
test_fs_js_apiby placing each test into a separate method. This PR was split from #19561 (comment). No functionality was changed.