Avoid invalid read in webgl1.c#20687
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Nov 11, 2023
Merged
Conversation
sbc100
force-pushed
the
extract_helper
branch
from
ac6e690 to
b01a684
Compare
kripken
approved these changes
Nov 11, 2023
sbc100
force-pushed
the
extract_helper
branch
from
b01a684 to
a05567c
Compare
Extract another helper function here which avoids the invalid read at address zero. Without this change a call to `emscripten_webgl_make_context_current(0)` would result in the second word of memory being compared to `pthread_self()`.
sbc100
force-pushed
the
extract_helper
branch
from
a05567c to
a26e243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract another helper function here which avoids the invalid read at address zero.
Without this change a call to
emscripten_webgl_make_context_current(0)would result in the second word of memory being compared topthread_self().Split out from #20678