Fix js-optimizer crash on empty array destructuring element#20843
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Dec 5, 2023
Merged
Fix js-optimizer crash on empty array destructuring element#20843sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
kripken
reviewed
Dec 5, 2023
kripken
approved these changes
Dec 5, 2023
sbc100
force-pushed
the
fix_js_optimizer
branch
from
95b30a8 to
933e098
Compare
Collaborator
Author
|
I reverted the extra asserts |
nsfisis
added a commit
to nsfisis/emscripten
that referenced
this pull request
Mar 10, 2024
…ement in function parameters It will fix a problem similar to emscripten-core#20843. emscripten-core#20843 fixed this case: ```javascript [, a] = x; ``` This commit will fix this case: ```javascript function ([, a]) { } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #20835.
Fixes: #20818