Drop support for targeting IE using -sMIN_IE_VESRION#20887
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Dec 11, 2023
Merged
Drop support for targeting IE using -sMIN_IE_VESRION#20887sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
Marking this one as draft since it less likely that just using |
Followup to emscripten-core#20881 which removed support for EdgeHTML
Collaborator
Author
|
@juj @kripken @RReverser @dschuff WDYT? |
sbc100
force-pushed
the
remove_min_ie_version
branch
from
4911764 to
fb977e6
Compare
Collaborator
|
Personally I'd go for this. If someone still targets IE for whatever reason, they are very unlikely to use Wasm projects IMO (even Wasm2JS), and likely already include tons of general polyfills, but I'll defer the decision to others. |
juj
approved these changes
Dec 11, 2023
Collaborator
juj
left a comment
juj
left a comment
There was a problem hiding this comment.
I thought retaining support for EdgeHTML would have been more important than the old IE.
I'm fully ok with dropping both forms of IEs. For us they are indeed long in the past.
Collaborator
Author
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #20881 which removed support for EdgeHTML