Define __LONG_MAX in alltypes.h #20930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is followup to emscripten-core#20752 which was supposed to define __LONG_MAX rather than LONG_MAX. You can see the effect of this change on some struct layouts in musl that contain checks like `#if __LONG_MAX > 0x7fffffff`. Since `__LONG_MAX` (and internal-only macro) is now correctly defined we get some slightly different values/layouts in libc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup to #20752 which was supposed to define __LONG_MAX rather than LONG_MAX.
You can see the effect of this change on some struct layouts in musl that contain checks like
#if __LONG_MAX > 0x7fffffff. Since__LONG_MAX(and internal-only macro) is now correctly defined we get some slightly different values/layouts in libc.