Skip to content

[ci] Update to latest version of cicleci windows orb#21110

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:update_circleci_windows
Jan 19, 2024
Merged

[ci] Update to latest version of cicleci windows orb#21110
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:update_circleci_windows

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Jan 19, 2024

We got a message saying that the version vs2019 will be deprecated this year. This change doesn't stop using vs2019, but just updates to the latest version of the windows orb. We may still need to move away from vs2019 in the future, but if possible we would like to continue testing on older version of windows so that we can be sure we continue to support them.

@sbc100 sbc100 requested a review from dschuff January 19, 2024 18:19
@sbc100 sbc100 enabled auto-merge (squash) January 19, 2024 18:19
Copy link
Copy Markdown
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it looks like we need to adjust the choco install command too.

We got a message saying that the version vs2019 will be deprecated this
year.  This change doesn't stop using vs2019, but just updates to the
latest version of the windows orb.  We may still need to move away from
vs2019 in the future, but if possible we would like to continue testing
on older version of windows so that we can be sure we continue to
support them.
@sbc100 sbc100 force-pushed the update_circleci_windows branch from f2b4dd4 to a34fdc8 Compare January 19, 2024 18:58
@sbc100 sbc100 merged commit edc1a75 into emscripten-core:main Jan 19, 2024
@sbc100 sbc100 deleted the update_circleci_windows branch January 19, 2024 20:06
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
wtu87830895-svg pushed a commit to wtu87830895-svg/emsdk2 that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants