[ci] Update to latest version of cicleci windows orb#21110
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Jan 19, 2024
Merged
[ci] Update to latest version of cicleci windows orb#21110sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
dschuff
approved these changes
Jan 19, 2024
Member
dschuff
left a comment
There was a problem hiding this comment.
LGTM but it looks like we need to adjust the choco install command too.
We got a message saying that the version vs2019 will be deprecated this year. This change doesn't stop using vs2019, but just updates to the latest version of the windows orb. We may still need to move away from vs2019 in the future, but if possible we would like to continue testing on older version of windows so that we can be sure we continue to support them.
f2b4dd4 to
a34fdc8
Compare
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Jan 29, 2024
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Jan 29, 2024
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Jan 29, 2024
wtu87830895-svg
pushed a commit
to wtu87830895-svg/emsdk2
that referenced
this pull request
Dec 20, 2025
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a message saying that the version vs2019 will be deprecated this year. This change doesn't stop using vs2019, but just updates to the latest version of the windows orb. We may still need to move away from vs2019 in the future, but if possible we would like to continue testing on older version of windows so that we can be sure we continue to support them.