Remove node 4 hack when assigning to .stack. NFC#21157
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Remove node 4 hack when assigning to .stack. NFC#21157sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
.stack. NFC#21157sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
#21149 fixes the TODO, but I think we should land this one first. |
sbc100
force-pushed
the
remove_node4_hack
branch
from
f9a0f82 to
b192940
Compare
kripken
approved these changes
Jan 24, 2024
I verified we don't see any errors on the oldest version of node that we support (10.19.0)
sbc100
force-pushed
the
remove_node4_hack
branch
from
b192940 to
5bf6008
Compare
Collaborator
Author
|
Closing in favor or #21149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I verified we don't see any errors on the oldest version of node that we support (10.19.0)