Remove duplicate proxying for emscripten_webgl_create_context#21200
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Remove duplicate proxying for emscripten_webgl_create_context#21200sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
The logic here for proxying this call seems to exist in both the JS code and in the native code. It seems to have been that way since it was added in emscripten-core#6254.
sbc100
changed the title
kripken
reviewed
Jan 29, 2024
| pthread_once(&tlsInit, InitWebGLTls); | ||
|
|
||
| if (attributes->proxyContextToMainThread == EMSCRIPTEN_WEBGL_CONTEXT_PROXY_ALWAYS || | ||
| (attributes->proxyContextToMainThread == EMSCRIPTEN_WEBGL_CONTEXT_PROXY_FALLBACK && !emscripten_supports_offscreencanvas())) { |
Member
There was a problem hiding this comment.
This check looks a little different than JS: it also has emscripten_supports_offscreencanvas. I don't know the offscreen canvas stuff well - is that not an issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic here for proxying this call seems to exist in both the JS
code and in the native code. It seems to have been that way since it
was added in #6254.